Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 8120001: Make it compile with -Werror on gcc 4.6 (Closed)

Created:
9 years, 2 months ago by ph34r
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Make it compile with -Werror on gcc 4.6 BUG=87490 TEST=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
A patches/gcc46.patch View 1 chunk +20 lines, -0 lines 0 comments Download
M public/common/unicode/unistr.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ph34r
9 years, 2 months ago (2011-10-03 13:32:13 UTC) #1
Nico
lgtm Thanks for the patch! Looks fine to me, but jshin owns all things ICU, ...
9 years, 2 months ago (2011-10-03 21:34:31 UTC) #2
Nico
lgtm lgtm Thanks for the patch! Looks fine to me, but jshin owns all things ...
9 years, 2 months ago (2011-10-03 21:34:33 UTC) #3
Nico
lgtm lgtm Thanks for the patch! Looks fine to me, but jshin owns all things ...
9 years, 2 months ago (2011-10-03 21:34:34 UTC) #4
Nico
(Sorry, I didn't mean to say "lgtm"; I hit the wrong button accidentally. s/lgtm// in ...
9 years, 2 months ago (2011-10-03 21:35:14 UTC) #5
ph34r
Jungshik Shin, ping :)
9 years, 2 months ago (2011-10-13 11:46:55 UTC) #6
jungshik at Google
On 2011/10/13 11:46:55, ph34r wrote: > Jungshik Shin, ping :) Sorry I missed this. Thanks ...
9 years, 2 months ago (2011-10-21 16:52:51 UTC) #7
jungshik at Google
It turned out that the upstream does not have this code any more. So, it's ...
9 years, 2 months ago (2011-10-21 17:16:12 UTC) #8
jungshik at Google
I landed it (http://crrev.com/106776) . Thank you for the patch.
9 years, 2 months ago (2011-10-21 20:50:48 UTC) #9
tony
9 years, 2 months ago (2011-10-21 20:58:31 UTC) #10
On 2011/10/21 20:50:48, Jungshik Shin wrote:
> I landed it (http://crrev.com/106776) . Thank you for the patch.

Jungshik, I think you missed the following:
http://code.google.com/p/chromium/issues/detail?id=97482#c5
http://codereview.chromium.org/8333007/

Powered by Google App Engine
This is Rietveld 408576698