Issue 8118032: Fix load of potentially eval-shadowed let bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8118032: Fix load of potentially eval-shadowed let bindings. (Closed)

Created:
9 years, 2 months ago by Steven

Modified:
9 years, 2 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix load of potentially eval-shadowed let bindings. BUG= TEST=test/mjsunit/harmony/block-let-semantics.js Committed: http://code.google.com/p/v8/source/detail?r=9541

Patch Set 1 #

Patch Set 2 : Fix test case. #

Patch Set 3 : Port to arm and x64. #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -7 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2	1 chunk	+10 lines, -2 lines	1 comment	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2	1 chunk	+8 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/block-let-semantics.js	View	1	2 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

9 years, 2 months ago (2011-10-06 13:34:03 UTC) #3

lgtm

http://codereview.chromium.org/8118032/diff/5001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/8118032/diff/5001/src/arm/full-codegen-arm.cc#...
src/arm/full-codegen-arm.cc:1233: } else {  // Variable::LE
Typo

Expand Messages | Collapse Messages