Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 8118030: Add Applescript commands to enter presentation mode (Closed)

Created:
9 years, 2 months ago by keishi
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add Applescript commands to enter presentation mode BUG=96915 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107079

Patch Set 1 #

Total comments: 4

Patch Set 2 : added comments #

Patch Set 3 : adapt to api change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript View 1 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/scripting.sdef View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
keishi
Supports enter/exit presentation mode and property boolean to tell if a window is in presentation ...
9 years, 2 months ago (2011-10-17 09:27:23 UTC) #1
pink (ping after 24hrs)
LGTM with comments. http://codereview.chromium.org/8118030/diff/1/chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript File chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript (right): http://codereview.chromium.org/8118030/diff/1/chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript#newcode1 chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript:1: -- Copyright (c) 2010 The Chromium ...
9 years, 2 months ago (2011-10-18 13:25:20 UTC) #2
keishi
Thanks! http://codereview.chromium.org/8118030/diff/1/chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript File chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript (right): http://codereview.chromium.org/8118030/diff/1/chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript#newcode1 chrome/browser/ui/cocoa/applescript/examples/window_operations.applescript:1: -- Copyright (c) 2010 The Chromium Authors. All ...
9 years, 2 months ago (2011-10-24 02:16:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/8118030/6002
9 years, 2 months ago (2011-10-24 12:39:30 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-24 13:43:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/8118030/6002
9 years, 2 months ago (2011-10-24 14:16:07 UTC) #6
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-24 15:37:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/8118030/6002
9 years, 2 months ago (2011-10-25 01:19:37 UTC) #8
commit-bot: I haz the power
Try job failure for 8118030-6002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years, 2 months ago (2011-10-25 02:25:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/8118030/12003
9 years, 2 months ago (2011-10-25 07:03:33 UTC) #10
commit-bot: I haz the power
9 years, 2 months ago (2011-10-25 08:39:35 UTC) #11
Change committed as 107079

Powered by Google App Engine
This is Rietveld 408576698