Issue 8118014: Check for null context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8118014: Check for null context (Closed)

Created:
9 years, 2 months ago by caryclark

Modified:
9 years, 2 months ago

Reviewers:
epoger, commit-bot: I haz the power, Stephen White

CC:
chromium-reviews, abarth-chromium, Mark Mentovai

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Check for null context https://bugs.webkit.org/show_bug.cgi?id=69149 describes a situation where running webkit tests sporadically crashes in the Debug build. The context returned by CGContextForData is NULL, so an early return prevents the BitmapPlatformDevice constructor from firing an assert in this case. The callers already anticipate a NULL result, and will propogate the error correctly. BUG=WK69149 TEST=run webkit tests in a Debug build repeatedly Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104374

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	skia/ext/bitmap_platform_device_mac.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/caryclark@google.com/8118014/1

9 years, 2 months ago (2011-10-06 20:22:24 UTC) #3

Change committed as 104374

Expand Messages | Collapse Messages