chrome/browser/resources/edit_search_engine_dialog.html - Issue 8118012: WebUI Edit Search Engine Dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/edit_search_engine_dialog.html

Issue 8118012: WebUI Edit Search Engine Dialog (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: validation images and button-strip fixups Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/resources/edit_search_engine_dialog.css ('k') | chrome/browser/resources/edit_search_engine_dialog.js » ('j') | chrome/browser/resources/edit_search_engine_dialog.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html i18n-values="dir:textdirection">

	3 <head>

	4 <meta charset="utf-8">

	5 <title></title>

	6 <link rel="stylesheet" href="edit_search_engine_dialog.css">

	7 <link rel="stylesheet" href="chrome://resources/css/button.css">

	8 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">

	9 <script src="strings.js"></script>

	10 <script src="chrome://resources/js/cr.js"></script>

	11 <script src="chrome://resources/js/cr/ui.js"></script>

	12 <script src="chrome://resources/js/i18n_template.js"></script>

	13 <script src="chrome://resources/js/util.js"></script>

	14 <script src="edit_search_engine_dialog.js"></script>

	15 </head>

	16

	17 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

	18 <table class="hfill">

	19 <tr>

	20 <td i18n-content="descriptionLabel"></td>

	21 <td class="hfill"><input id="description-text" class="hfill"></td>

	22 <td><div class="invalid" id="description-icon"></div></td>

	23 </tr>

	24 <tr>

	25 <td i18n-content="keywordLabel"></td>

	26 <td class="hfill"><input id="keyword-text" class="hfill"></td>

	27 <td><div class="invalid" id="keyword-icon"></div></td>

	28 </tr>

	29 <tr>

	30 <td i18n-content="urlLabel"></td>

	31 <td class="hfill"><input id="url-text" class="hfill"></td>

	32 <td><div class="invalid" id="url-icon"></div></td>

	33 </tr>

	34 </table>

	35 <div i18n-content="urlDescriptionLabel" id="url-description"></div>

	36 <div class="action-area">

	37 <div class="button-strip">

	38 <button id="cancel" i18n-content="cancel"></button>

	39 <button id="save" i18n-content="save"></button>

	40 </div>

	41 </div>
	flackr 2011/10/11 18:05:35 To support RTL and have minimal markup, would this To support RTL and have minimal markup, would this work? http://jsfiddle.net/u5JKF/ HTML: <div id="action-area"> <button>Connect</button> <button>Cancel</button> </div> CSS: #action-area { text-align: end; } arv (Not doing code reviews) 2011/10/11 18:28:31 Yes. But we also need to change the order based o Show quoted text On 2011/10/11 18:05:35, flackr wrote: > To support RTL and have minimal markup, would this work? > http://jsfiddle.net/u5JKF/ > > HTML: > <div id="action-area"> > <button>Connect</button> > <button>Cancel</button> > </div> > > CSS: > #action-area { > text-align: end; > } Yes. But we also need to change the order based on the OS.
	42 </body>

	43 </html>

OLD	NEW