Fix to hide Edit Items button when there are no items in history

chrome/browser/resources/history.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 var RESULTS_PER_PAGE = 150;
 var MAX_SEARCH_DEPTH_MONTHS = 18;
 
 // Amount of time between pageviews that we consider a 'break' in browsing,
@@ skipping 458 matching lines @@
 
   this.model_.setView(this);
 
   this.currentPages_ = [];
 
   var self = this;
   window.onresize = function() {
     self.updateEntryAnchorWidth_();
   };
   self.updateEditControls_();
+  this.editButtonTd_.hidden = true;

[James Hawkins, 2011/10/15 20:39:43]

Inconsistent. The line directly above this uses self instead of this. Personally
I think the line above should be changed s/self/this/.

[NaveenBobbili (Motorola), 2011/10/18 04:12:43]

Done.

 
   this.boundUpdateRemoveButton_ = function(e) {
     return self.updateRemoveButton_(e);
   };
 }
 
 // HistoryView, public: -------------------------------------------------------
 /**
  * Do a search and optionally view a certain page.
  * @param {string} term The string to search for.
@@ skipping 87 matching lines @@
 
 HistoryView.prototype.setPageRendered_ = function(page) {
   page.isRendered = true;
   this.currentPages_.push(page);
 };
 
 /**
  * Update the page with results.
  */
 HistoryView.prototype.displayResults_ = function() {
+  // Hide the Edit Button if we are not in edit mode and

[James Hawkins, 2011/10/15 20:39:43]

Don't use 'we' in comments; it's ambiguous.

[James Hawkins, 2011/10/15 20:39:43]

nit: Fill up the 80 cols when writing comments instead of wrapping randomly.

[NaveenBobbili (Motorola), 2011/10/18 04:12:43]

Done.

[NaveenBobbili (Motorola), 2011/10/18 04:12:43]

Done.

+  // if there are no history results to show.
+  if (this.model_.getSize() <= 0 && !this.model_.getEditMode())

[James Hawkins, 2011/10/15 20:39:43]

When can getSize() return a number < 0?

[James Hawkins, 2011/10/15 20:39:43]

this.editButtonTd_.hidden = this.model_.getSize()...;

[NaveenBobbili (Motorola), 2011/10/18 04:12:43]

Done.

[NaveenBobbili (Motorola), 2011/10/18 04:12:43]

Done.

+    this.editButtonTd_.hidden = true;
+  else
+    this.editButtonTd_.hidden = false;
+
   var results = this.model_.getNumberedRange(
       this.pageIndex_ * RESULTS_PER_PAGE,
       this.pageIndex_ * RESULTS_PER_PAGE + RESULTS_PER_PAGE);
 
   if (this.model_.getSearchText()) {
     var resultTable = createElementWithClassName('table', 'results');
     resultTable.cellSpacing = 0;
     resultTable.cellPadding = 0;
     resultTable.border = 0;
 
@@ skipping 468 matching lines @@
  * else).
  */
 function historyDeleted() {
   window.console.log('History deleted');
   var anyChecked = document.querySelector('.entry input:checked') != null;
   if (!(historyView.getEditMode() && anyChecked))
     historyView.reload();
 }
 
 document.addEventListener('DOMContentLoaded', load);