Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 8117001: Remove #include "isolate-inl.h" from v8.h. (Closed)

Created:
9 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 2 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Remove #include "isolate-inl.h" from v8.h. Include it only in the .cc files where it's needed. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9506

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -132 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug.h View 1 chunk +2 lines, -85 lines 0 comments Download
M src/debug.cc View 2 chunks +89 lines, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/frames.h View 12 chunks +22 lines, -29 lines 1 comment Download
M src/frames.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/frames-inl.h View 4 chunks +65 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -13 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/jsregexp.h View 2 chunks +2 lines, -1 line 1 comment Download
M src/runtime.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
http://codereview.chromium.org/8117001/diff/1/src/frames.h File src/frames.h (right): http://codereview.chromium.org/8117001/diff/1/src/frames.h#newcode109 src/frames.h:109: inline bool is_entry() const; Removing isolate-inl.h from v8.h revealed ...
9 years, 2 months ago (2011-10-03 10:45:40 UTC) #1
fschneider
9 years, 2 months ago (2011-10-03 11:04:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698