Issue 8117: Pulling in latest software construction toolkit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8117: Pulling in latest software construction toolkit. (Closed)

Created:
12 years, 2 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
tony, tc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Pulling in latest software construction toolkit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3861

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+557 lines, -103 lines)			Patch
M	site_scons/site_init.py	View	8 chunks	+59 lines, -37 lines	0 comments	Download
M	site_scons/site_tools/atlmfc_vc80.py	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	site_scons/site_tools/collada_dom.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	site_scons/site_tools/command_output.py	View	4 chunks	+117 lines, -13 lines	0 comments	Download
M	site_scons/site_tools/component_bits.py	View	9 chunks	+60 lines, -14 lines	0 comments	Download
M	site_scons/site_tools/component_builders.py	View	12 chunks	+79 lines, -10 lines	0 comments	Download
M	site_scons/site_tools/concat_source.py	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	site_scons/site_tools/defer.py	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	site_scons/site_tools/directx_9_0_c.py	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	site_scons/site_tools/distcc.py	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	site_scons/site_tools/gather_inputs.py	View	2 chunks	+20 lines, -5 lines	0 comments	Download
A	site_scons/site_tools/sdl.py	View	1 chunk	+176 lines, -0 lines	0 comments	Download
M	site_scons/site_tools/target_platform_linux.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	site_scons/site_tools/target_platform_mac.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	site_scons/site_tools/target_platform_windows.py	View	5 chunks	+17 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

tony

12 years, 2 months ago (2008-10-23 21:18:02 UTC) #2

If this is coming from somewhere upstream, shouldn't it be in third_party with a
README.google and LICENSE file?

Otherwise, Rubber stamp LGTM.