Switch remoting/protocol to new callbacks

Switch remoting/protocol to new callbacks

There is still some code that uses old callbacks (particularly unittests) - I will convert them in a separate CL.

BUG=None
TEST=Unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104440

[awong, 2011-10-04 01:18:07]

LGTM

YAY!

Thanks!

http://codereview.chromium.org/8116021/diff/1/remoting/protocol/video_stub.h
File remoting/protocol/video_stub.h (right):

http://codereview.chromium.org/8116021/diff/1/remoting/protocol/video_stub.h#...
remoting/protocol/video_stub.h:8: #include "base/callback.h"
FYI, You can still forward declare base::Closure if you want.  But #including
works just as well.  Your choice.

[Sergey Ulanov, 2011-10-04 01:27:28]

http://codereview.chromium.org/8116021/diff/1/remoting/protocol/video_stub.h
File remoting/protocol/video_stub.h (right):

http://codereview.chromium.org/8116021/diff/1/remoting/protocol/video_stub.h#...
remoting/protocol/video_stub.h:8: #include "base/callback.h"
On 2011/10/04 01:18:07, awong wrote:
> FYI, You can still forward declare base::Closure if you want.  But #including
> works just as well.  Your choice.

I tried it, but GCC doesn't like it because Closure is a typedef, not a class:
../../remoting/protocol/video_stub.h:9: error: using typedef-name
‘base::Closure’ after ‘class’
../../base/callback.h:551: error: ‘base::Closure’ has a previous declaration
here

[awong, 2011-10-04 01:50:24]

LGTM++

Ah. stupid typedefs.

On Mon, Oct 3, 2011 at 6:27 PM, <sergeyu@chromium.org> wrote:

>
> http://codereview.chromium.**org/8116021/diff/1/remoting/**
>
protocol/video_stub.h<http://codereview.chromium.org/8116021/diff/1/remoting/protocol/video_stub.h>
> File remoting/protocol/video_stub.h (right):
>
> http://codereview.chromium.**org/8116021/diff/1/remoting/**
>
protocol/video_stub.h#newcode8<http://codereview.chromium.org/8116021/diff/1/remoting/protocol/video_stub.h#newcode8>
> remoting/protocol/video_stub.**h:8: #include "base/callback.h"
> On 2011/10/04 01:18:07, awong wrote:
>
>> FYI, You can still forward declare base::Closure if you want.  But
>>
> #including
>
>> works just as well.  Your choice.
>>
>
> I tried it, but GCC doesn't like it because Closure is a typedef, not a
> class:
> ../../remoting/protocol/video_**stub.h:9: error: using typedef-name
> ‘base::Closure’ after ‘class’
> ../../base/callback.h:551: error: ‘base::Closure’ has a previous
> declaration here
>
>
http://codereview.chromium.**org/8116021/<http://codereview.chromium.org/8116...
>

[commit-bot: I haz the power, 2011-10-04 20:14:37]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8116021/5001

[commit-bot: I haz the power, 2011-10-04 20:14:46]

Can't process patch for file remoting/protocol/protocol_mock_objects.h.
File's status is None, patchset upload is incomplete.

[commit-bot: I haz the power, 2011-10-06 20:23:42]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8116021/9001

[commit-bot: I haz the power, 2011-10-06 20:23:48]

Can't process patch for file remoting/protocol/protocol_mock_objects.h.
File's status is None, patchset upload is incomplete.