Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 8116015: Now closes existing background contents if app opens a new one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed a few comments. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/app_background_page_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index bc3e6062d18e3acdb8dd3919983c16d67f048ab2..748f272350002b79b2f46e0768f6c56e3336cdfe 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -357,7 +357,9 @@ void BackgroundContentsService::LoadBackgroundContentsFromPrefs(
// crash before we could save our prefs.
NOTREACHED() << "No extension found for BackgroundContents - id = "
<< *it;
- return;
+ // Don't cancel out of our loop, just ignore this BackgroundContents and
+ // load the next one.
+ continue;
rafaelw 2011/10/04 20:10:28 It seems wrong to leave the NOTREACHED() here. Als
Andrew T Wilson (Slow) 2011/10/04 21:12:05 Updated the comment. Let me know if you want this
}
LoadBackgroundContentsFromDictionary(profile, *it, contents);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/app_background_page_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698