chrome/browser/resources/history.js - Issue 8116002: Fix for disabling the remove Button when there are no selected items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history.js

Issue 8116002: Fix for disabling the remove Button when there are no selected items. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Fix for disabling the remove Button when there are no selected items Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/history.js

diff --git a/chrome/browser/resources/history.js b/chrome/browser/resources/history.js

index 183f42c6aa8514bfc7aa6b72d75cdd0d86bf1fbf..775970583af2e4bc058b9e1b2e39dda60f985028 100644

--- a/chrome/browser/resources/history.js

+++ b/chrome/browser/resources/history.js

@@ -994,6 +994,8 @@ function removeItems() {

if (confirm(localStrings.getString('deletewarning'))) {

deleteQueue = deleteQueue.concat(queue);

deleteNextInQueue();

+ // Disable the remove button.

James Hawkins 2011/10/15 20:35:43 Remove redundant comment.

NaveenBobbili (Motorola) 2011/10/18 04:12:33 Done.

+ historyView.removeButton_.disabled = true;

} else {

// If the remove is cancelled, return the checkboxes to their

// enabled, non-line-through state.

« no previous file with comments | « no previous file | no next file » | no next file with comments »