Add hinting to improve ASLR for macos (all allocations) and linux (newly added allocation types).

Add hinting to improve ASLR for macos (all allocations) and linux (newly added allocation types).

TEST=N/A
BUG=1749
Committed: http://code.google.com/p/v8/source/detail?r=9572

[Vyacheslav Egorov (Chromium), 2011-10-04 09:18:33]

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode459
src/platform-linux.cc:459: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
preferred formatting is one arguments per line

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode475
src/platform-linux.cc:475: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
ditto

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode561
src/platform-linux.cc:561: void* addr = mmap(GetRandomMmapAddr(), size,
PROT_READ | PROT_EXEC,
ditto

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc
File src/platform-macos.cc (right):

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode95
src/platform-macos.cc:95: static void* GetRandomMmapAddr() {
consider moving somewhere (e.g. platfrom-posix.cc) to avoid duplication.

platform can define the range of unpopular addresses which shared implementation
would use.

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode169
src/platform-macos.cc:169: void* mbase = mmap(GetRandomMmapAddr(), msize, prot,
formatting: one argument per line

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode228
src/platform-macos.cc:228: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
formatting: one argument per line

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode244
src/platform-macos.cc:244: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
formatting: one argument per line

[Cris Neckar, 2011-10-04 19:20:47]

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode459
src/platform-linux.cc:459: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> preferred formatting is one arguments per line

Done.

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode475
src/platform-linux.cc:475: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> ditto

Done.

http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode561
src/platform-linux.cc:561: void* addr = mmap(GetRandomMmapAddr(), size,
PROT_READ | PROT_EXEC,
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> ditto

Done.

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc
File src/platform-macos.cc (right):

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode95
src/platform-macos.cc:95: static void* GetRandomMmapAddr() {
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> consider moving somewhere (e.g. platfrom-posix.cc) to avoid duplication.
> 
> platform can define the range of unpopular addresses which shared
implementation
> would use.

Done.

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode169
src/platform-macos.cc:169: void* mbase = mmap(GetRandomMmapAddr(), msize, prot,
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> formatting: one argument per line

Done.

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode228
src/platform-macos.cc:228: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> formatting: one argument per line

Done.

http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode244
src/platform-macos.cc:244: mmap(GetRandomMmapAddr(), size, PROT_READ |
PROT_WRITE,
On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> formatting: one argument per line

Done.

[Cris Neckar, 2011-10-05 18:34:34]

Assuming this new patch is OK can you also commit it for me.

Thanks!

On 2011/10/04 19:20:47, Cris Neckar wrote:
> http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc
> File src/platform-linux.cc (right):
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode459
> src/platform-linux.cc:459: mmap(GetRandomMmapAddr(), size, PROT_READ |
> PROT_WRITE,
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > preferred formatting is one arguments per line
> 
> Done.
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode475
> src/platform-linux.cc:475: mmap(GetRandomMmapAddr(), size, PROT_READ |
> PROT_WRITE,
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > ditto
> 
> Done.
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-linux.cc#newcode561
> src/platform-linux.cc:561: void* addr = mmap(GetRandomMmapAddr(), size,
> PROT_READ | PROT_EXEC,
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > ditto
> 
> Done.
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc
> File src/platform-macos.cc (right):
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode95
> src/platform-macos.cc:95: static void* GetRandomMmapAddr() {
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > consider moving somewhere (e.g. platfrom-posix.cc) to avoid duplication.
> > 
> > platform can define the range of unpopular addresses which shared
> implementation
> > would use.
> 
> Done.
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode169
> src/platform-macos.cc:169: void* mbase = mmap(GetRandomMmapAddr(), msize,
prot,
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > formatting: one argument per line
> 
> Done.
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode228
> src/platform-macos.cc:228: mmap(GetRandomMmapAddr(), size, PROT_READ |
> PROT_WRITE,
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > formatting: one argument per line
> 
> Done.
> 
> http://codereview.chromium.org/8115014/diff/1/src/platform-macos.cc#newcode244
> src/platform-macos.cc:244: mmap(GetRandomMmapAddr(), size, PROT_READ |
> PROT_WRITE,
> On 2011/10/04 09:18:33, Vyacheslav Egorov wrote:
> > formatting: one argument per line
> 
> Done.

[Vyacheslav Egorov (Chromium), 2011-10-10 14:13:14]

fixed nits myself and landing.

http://codereview.chromium.org/8115014/diff/9001/src/platform-linux.cc
File src/platform-linux.cc (left):

http://codereview.chromium.org/8115014/diff/9001/src/platform-linux.cc#oldcod...
src/platform-linux.cc:106: 
accidentally deleted new line

http://codereview.chromium.org/8115014/diff/9001/src/platform-macos.cc
File src/platform-macos.cc (left):

http://codereview.chromium.org/8115014/diff/9001/src/platform-macos.cc#oldcode95
src/platform-macos.cc:95: 
accidentally deleted new line

http://codereview.chromium.org/8115014/diff/9001/src/platform-posix.cc
File src/platform-posix.cc (right):

http://codereview.chromium.org/8115014/diff/9001/src/platform-posix.cc#newcode85
src/platform-posix.cc:85: 
one more new line required

[Vyacheslav Egorov (Chromium), 2011-10-10 14:13:19]

lgtm