Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: src/serialize.cc

Issue 8114032: Clean list of external references from internal objects like the hole value. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 "StoreBuffer::StoreBufferOverflow"); 311 "StoreBuffer::StoreBufferOverflow");
312 Add(ExternalReference:: 312 Add(ExternalReference::
313 incremental_evacuation_record_write_function(isolate).address(), 313 incremental_evacuation_record_write_function(isolate).address(),
314 RUNTIME_ENTRY, 314 RUNTIME_ENTRY,
315 7, 315 7,
316 "IncrementalMarking::RecordWrite"); 316 "IncrementalMarking::RecordWrite");
317 317
318 318
319 319
320 // Miscellaneous 320 // Miscellaneous
321 Add(ExternalReference::the_hole_value_location(isolate).address(),
322 UNCLASSIFIED,
323 2,
324 "Factory::the_hole_value().location()");
325 Add(ExternalReference::roots_address(isolate).address(), 321 Add(ExternalReference::roots_address(isolate).address(),
326 UNCLASSIFIED, 322 UNCLASSIFIED,
327 3, 323 3,
328 "Heap::roots_address()"); 324 "Heap::roots_address()");
329 Add(ExternalReference::address_of_stack_limit(isolate).address(), 325 Add(ExternalReference::address_of_stack_limit(isolate).address(),
330 UNCLASSIFIED, 326 UNCLASSIFIED,
331 4, 327 4,
332 "StackGuard::address_of_jslimit()"); 328 "StackGuard::address_of_jslimit()");
333 Add(ExternalReference::address_of_real_stack_limit(isolate).address(), 329 Add(ExternalReference::address_of_real_stack_limit(isolate).address(),
334 UNCLASSIFIED, 330 UNCLASSIFIED,
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 41, 479 41,
484 "power_double_double_function"); 480 "power_double_double_function");
485 Add(ExternalReference::power_double_int_function(isolate).address(), 481 Add(ExternalReference::power_double_int_function(isolate).address(),
486 UNCLASSIFIED, 482 UNCLASSIFIED,
487 42, 483 42,
488 "power_double_int_function"); 484 "power_double_int_function");
489 Add(ExternalReference::store_buffer_top(isolate).address(), 485 Add(ExternalReference::store_buffer_top(isolate).address(),
490 UNCLASSIFIED, 486 UNCLASSIFIED,
491 43, 487 43,
492 "store_buffer_top"); 488 "store_buffer_top");
493 Add(ExternalReference::arguments_marker_location(isolate).address(), 489 Add(ExternalReference::address_of_canonical_non_hole_nan().address(),
494 UNCLASSIFIED, 490 UNCLASSIFIED,
495 44, 491 44,
496 "Factory::arguments_marker().location()");
497 Add(ExternalReference::address_of_canonical_non_hole_nan().address(),
498 UNCLASSIFIED,
499 45,
500 "canonical_nan"); 492 "canonical_nan");
501 } 493 }
502 494
503 495
504 ExternalReferenceEncoder::ExternalReferenceEncoder() 496 ExternalReferenceEncoder::ExternalReferenceEncoder()
505 : encodings_(Match), 497 : encodings_(Match),
506 isolate_(Isolate::Current()) { 498 isolate_(Isolate::Current()) {
507 ExternalReferenceTable* external_references = 499 ExternalReferenceTable* external_references =
508 ExternalReferenceTable::instance(isolate_); 500 ExternalReferenceTable::instance(isolate_);
509 for (int i = 0; i < external_references->size(); ++i) { 501 for (int i = 0; i < external_references->size(); ++i) {
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1561 fullness_[space] = RoundUp(fullness_[space], Page::kPageSize); 1553 fullness_[space] = RoundUp(fullness_[space], Page::kPageSize);
1562 } 1554 }
1563 } 1555 }
1564 int allocation_address = fullness_[space]; 1556 int allocation_address = fullness_[space];
1565 fullness_[space] = allocation_address + size; 1557 fullness_[space] = allocation_address + size;
1566 return allocation_address; 1558 return allocation_address;
1567 } 1559 }
1568 1560
1569 1561
1570 } } // namespace v8::internal 1562 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698