Issue 8114006: Reland the patch to fix the problem that sometimes panel on Windows is not set to top-most.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8114006: Reland the patch to fix the problem that sometimes panel on Windows is not set to top-most. (Closed)

Created:
9 years, 2 months ago by jianli

Modified:
9 years, 2 months ago

Reviewers:

CC:
chromium-reviews, jennb, Dmitry Titov, jianli, prasadt, dcheng, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reland the patch to fix the problem that sometimes panel on Windows is not set to top-most. This could happen when we try to make the window top-most after it has been created without activation. This seems to be a bug or feature on Windows that some users have been complaining about. To fix this problem, I changed BrowserFrame::InitBrowserFrame to pass the keep_on_top flag when the panel is to be created. I have also added windows specific testing code to check the styles in the browser test. BUG=none TEST=browser test TBR=dimich Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103741

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -100 lines)			Patch
M	chrome/browser/ui/panels/panel_browser_frame_view.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_view_browsertest.cc	View	7 chunks	+220 lines, -94 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download