Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/content_browser_client.h

Issue 8113035: Remove RenderProcessHost::is_extension_process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_process_manager.h ('K') | « content/browser/child_process_launcher.cc ('k') | content/browser/mock_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/content_browser_client.h
diff --git a/content/browser/content_browser_client.h b/content/browser/content_browser_client.h
index 0597954f07f893b4756383680023b1c2000505a1..8317c4b93e345bbc5f3433899ca1ed5066a97eee 100644
--- a/content/browser/content_browser_client.h
+++ b/content/browser/content_browser_client.h
@@ -302,8 +302,9 @@ class ContentBrowserClient {
virtual FilePath GetDefaultDownloadDirectory() = 0;
#if defined(OS_POSIX) && !defined(OS_MACOSX)
- // Can return an optional fd for crash handling, otherwise returns -1.
- virtual int GetCrashSignalFD(const std::string& process_type) = 0;
+ // Can return an optional fd for crash handling, otherwise returns -1. The
+ // passed |command_line| will be used to start the process in question.
+ virtual int GetCrashSignalFD(const CommandLine* command_line) = 0;
jam 2011/10/04 16:59:22 nit: const reference
jochen (gone - plz use gerrit) 2011/10/04 18:50:19 Done.
#endif
#if defined(OS_WIN)
« chrome/browser/extensions/extension_process_manager.h ('K') | « content/browser/child_process_launcher.cc ('k') | content/browser/mock_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698