Issue 8113034: Adjust contents of kAheadOfTime to match write-barrier stub called from CompileArrayPushCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8113034: Adjust contents of kAheadOfTime to match write-barrier stub called from CompileArrayPushCall. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Adjust contents of kAheadOfTime to match write-barrier stub called from CompileArrayPushCall. R=erik.corry@gmail.com BUG=v8:1729 Committed: http://code.google.com/p/v8/source/detail?r=9513

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	tools/gcmole/gccause.lua	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

lgtm http://codereview.chromium.org/8113034/diff/1/tools/gcmole/gccause.lua File tools/gcmole/gccause.lua (right): http://codereview.chromium.org/8113034/diff/1/tools/gcmole/gccause.lua#newcode52 tools/gcmole/gccause.lua:52: if f == '<GC>' then break end Deliberate?

9 years, 2 months ago (2011-10-04 11:25:23 UTC) #2

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-10-04 11:30:29 UTC) #3

http://codereview.chromium.org/8113034/diff/1/tools/gcmole/gccause.lua
File tools/gcmole/gccause.lua (right):

http://codereview.chromium.org/8113034/diff/1/tools/gcmole/gccause.lua#newcode52
tools/gcmole/gccause.lua:52: if f == '<GC>' then break end
On 2011/10/04 11:25:23, Erik Corry wrote:
> Deliberate?

Yes. Otherwise it goes too deep.

Expand Messages | Collapse Messages