Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc

Issue 8113031: Change std::wstring to string16 for views::Label and views::Link (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.cc ('k') | chrome/browser/ui/views/avatar_menu_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
index 35bb187bee979dd408c358fd18c510ee1e34c5a8..3ee4c06cfdbf44523105bd41be8a5d726a1420ff 100644
--- a/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
+++ b/chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc
@@ -4,6 +4,12 @@
#include "chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h"
+#if defined(OS_WIN)
+#include <commctrl.h>
+#include <dwmapi.h>
+#include <objidl.h>
+#endif
+
#include "base/compiler_specific.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/autocomplete/autocomplete_popup_model.h"
@@ -33,10 +39,6 @@
#include "views/widget/widget.h"
#if defined(OS_WIN)
-#include <commctrl.h>
-#include <dwmapi.h>
-#include <objidl.h>
-
#include "base/win/scoped_gdi_object.h"
#if !defined(USE_AURA)
#include "views/widget/native_widget_win.h"
@@ -148,7 +150,7 @@ class AutocompletePopupContentsView::AutocompletePopupWidget
virtual ~AutocompletePopupWidget() {}
private:
- DISALLOW_COPY_AND_ASSIGN(AutocompletePopupWidget);
+ DISALLOW_COPY_AND_ASSIGN(AutocompletePopupWidget);
};
class AutocompletePopupContentsView::InstantOptInView
@@ -163,7 +165,7 @@ class AutocompletePopupContentsView::InstantOptInView
SkColorSetRGB(255, 242, 183),
SkColorSetRGB(250, 230, 145))) {
views::Label* label = new views::Label(
- UTF16ToWide(l10n_util::GetStringUTF16(IDS_INSTANT_OPT_IN_LABEL)));
+ l10n_util::GetStringUTF16(IDS_INSTANT_OPT_IN_LABEL));
label->SetFont(label_font);
views::GridLayout* layout = new views::GridLayout(this);
@@ -211,8 +213,8 @@ class AutocompletePopupContentsView::InstantOptInView
views::View* CreateButton(int id, const gfx::Font& font) {
// NOTE: we can't use NativeButton as the popup is a layered window and
// native buttons don't draw in layered windows.
- // TODO: these buttons look crap. Figure out the right border/background to
- // use.
+ // TODO(sky): these buttons look crap. Figure out the right
+ // border/background to use.
views::TextButton* button =
new views::TextButton(this, UTF16ToWide(l10n_util::GetStringUTF16(id)));
button->set_border(new OptInButtonBorder());
@@ -320,7 +322,7 @@ void AutocompletePopupContentsView::UpdatePopupAppearance() {
// we have enough row views.
size_t child_rv_count = child_count();
if (opt_in_view_) {
- DCHECK(child_rv_count > 0);
+ DCHECK_GT(child_rv_count, 0u);
child_rv_count--;
}
for (size_t i = 0; i < model_->result().size(); ++i) {
@@ -373,8 +375,8 @@ void AutocompletePopupContentsView::UpdatePopupAppearance() {
if (!popup_.get()) {
// For some IMEs GetRelativeWindowForPopup triggers the omnibox to lose
// focus, thereby closing (and destroying) the popup.
- // TODO: this won't be needed once we close the omnibox on input window
- // showing.
+ // TODO(sky): this won't be needed once we close the omnibox on input
+ // window showing.
return;
}
popup_->Show();
« no previous file with comments | « chrome/browser/ui/views/about_chrome_view.cc ('k') | chrome/browser/ui/views/avatar_menu_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698