Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8113031: Change std::wstring to string16 for views::Label and views::Link (Closed)

Created:
9 years, 2 months ago by yosin_UTC9
Modified:
9 years, 2 months ago
CC:
chromium-reviews, asanka, stevenjb, jennb, nkostylev+watch_chromium.org, tfarina, Randy Smith (Not in Mondays), mihaip+watch_chromium.org, prasadt, dcheng, Dmitry Titov, Aaron Boodman, jianli, Paweł Hajdan Jr., Erik does not do reviews, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Change std::wstring to string16 for views::Link Change wst::string to string16 for view::Label and views::Link BUG=68267 TEST=no user visible changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104076

Patch Set 1 : Initial submit #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -456 lines) Patch
M chrome/browser/chromeos/frame/bubble_frame_view.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/frame/panel_controller.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 8 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/background_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/captcha_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/eula_view.cc View 7 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/login/message_bubble.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/network_selection_view.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/take_photo_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/update_view.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/user_controller.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_view.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/user_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/username_view.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 17 chunks +27 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.cc View 1 15 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/speech/speech_input_bubble_views.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/input_window_dialog_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browser_frame_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 1 7 chunks +28 lines, -30 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 7 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 7 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 6 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/default_search_view.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_in_progress_dialog_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_in_progress_dialog_view.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/importer/import_progress_dialog_view.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/indexed_db_info_view.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/local_storage_info_view.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/local_storage_set_item_info_view.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/login_view.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/uninstall_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M views/controls/label.h View 5 chunks +8 lines, -7 lines 0 comments Download
M views/controls/label.cc View 9 chunks +21 lines, -19 lines 0 comments Download
M views/controls/label_unittest.cc View 14 chunks +15 lines, -14 lines 0 comments Download
M views/controls/link.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/link.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M views/controls/message_box_view.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M views/examples/examples_main.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 12 chunks +15 lines, -16 lines 0 comments Download
M views/widget/tooltip_manager_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yosin_UTC9
Hi Sky, Could you review my changes? -yosi P.S. Sorry for so many files. At ...
9 years, 2 months ago (2011-10-04 13:10:30 UTC) #1
sky
LGTM
9 years, 2 months ago (2011-10-04 15:51:09 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/8113031/6001
9 years, 2 months ago (2011-10-05 06:56:47 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-05 08:29:31 UTC) #4 
Change committed as 104076

Powered by Google App Engine
This is Rietveld 408576698