Issue 8113029: Cleanup: Remove dead code - printing::PrintedPagesSource::RenderSourceName() and printing::Printe...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8113029: Cleanup: Remove dead code - printing::PrintedPagesSource::RenderSourceName() and printing::Printe... (Closed)

Created:
9 years, 2 months ago by Lei Zhang

Modified:
9 years, 2 months ago

Reviewers:
vandebo (ex-Chrome), commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Remove dead code - printing::PrintedPagesSource::RenderSourceName() and printing::PrintedDocument::url(). They were only used by the old headers/footers code. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103970

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -35 lines)			Patch
M	chrome/browser/printing/print_job_unittest.cc	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	printing/printed_document.h	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	printing/printed_document.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	printing/printed_pages_source.h	View	3 chunks	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8113029/1

9 years, 2 months ago (2011-10-04 18:44:33 UTC) #3

Change committed as 103970

Expand Messages | Collapse Messages