Issue 8113027: Export some unix-specific content symbols

Issue 8113027: Export some unix-specific content symbols (Closed)

Created:
9 years, 2 months ago by Dirk Pranke

Modified:
9 years, 2 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Export some unix-specific content symbols. R=jam@chromium.org BUG=90442 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103929

Patch Set 1 #

Patch Set 2 : more exports #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -33 lines)			Patch
M	chrome/renderer/chrome_ppb_pdf_impl.cc	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/cancelable_request.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/download/drag_download_util.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/geolocation/gps_location_provider_linux.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/geolocation/libgps_wrapper_linux.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_linux.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/backing_store_gtk.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/backing_store_manager.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/gtk_key_bindings_handler.h	View	1	2 chunks	+2 lines, -1 line	1 comment	Download
M	content/browser/renderer_host/render_sandbox_host_linux.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/resource_queue.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/speech/speech_input_dispatcher_host.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/browser/speech/speech_input_dispatcher_host.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/zygote_host_linux.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/common/child_process_sandbox_support_linux.h	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download
M	content/common/content_constants.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/pepper_messages.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/common/process_watcher.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/unix_domain_socket_posix.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/content_shell.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/renderer/render_view.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

9 years, 2 months ago (2011-10-04 16:48:32 UTC) #2

lgtm

http://codereview.chromium.org/8113027/diff/2001/content/browser/renderer_hos...
File content/browser/renderer_host/gtk_key_bindings_handler.h (right):

http://codereview.chromium.org/8113027/diff/2001/content/browser/renderer_hos...
content/browser/renderer_host/gtk_key_bindings_handler.h:14: #include
"content/common/content_export.h"
nit: ordering

Expand Messages | Collapse Messages