Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: chrome/browser/chromeos/version_loader.cc

Issue 8113025: base::Bind: More converts, mostly in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/version_loader.h ('k') | chrome/browser/ui/webui/bug_report_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/version_loader.cc
diff --git a/chrome/browser/chromeos/version_loader.cc b/chrome/browser/chromeos/version_loader.cc
index 802373973d378c409ea3939d2f4cf74b1d06d6eb..cebed1775486d6b4fc01a5e69c9f646b87cbcede 100644
--- a/chrome/browser/chromeos/version_loader.cc
+++ b/chrome/browser/chromeos/version_loader.cc
@@ -44,7 +44,7 @@ const char VersionLoader::kFirmwarePrefix[] = "version";
VersionLoader::Handle VersionLoader::GetVersion(
CancelableRequestConsumerBase* consumer,
- VersionLoader::GetVersionCallback* callback,
+ const VersionLoader::GetVersionCallback& callback,
VersionFormat format) {
if (!g_browser_process->file_thread()) {
// This should only happen if Chrome is shutting down, so we don't do
@@ -63,7 +63,7 @@ VersionLoader::Handle VersionLoader::GetVersion(
VersionLoader::Handle VersionLoader::GetFirmware(
CancelableRequestConsumerBase* consumer,
- VersionLoader::GetFirmwareCallback* callback) {
+ const VersionLoader::GetFirmwareCallback& callback) {
if (!g_browser_process->file_thread()) {
// This should only happen if Chrome is shutting down, so we don't do
// anything.
@@ -154,8 +154,7 @@ void VersionLoader::Backend::GetVersion(
}
}
- request->ForwardResult(GetVersionCallback::TupleType(request->handle(),
- version));
+ request->ForwardResult(request->handle(), version);
}
void VersionLoader::Backend::GetFirmware(
@@ -171,8 +170,7 @@ void VersionLoader::Backend::GetFirmware(
firmware = ParseFirmware(contents);
}
- request->ForwardResult(GetFirmwareCallback::TupleType(request->handle(),
- firmware));
+ request->ForwardResult(request->handle(), firmware);
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/version_loader.h ('k') | chrome/browser/ui/webui/bug_report_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698