Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/chromeos/system/syslogs_provider.cc

Issue 8113025: base::Bind: More converts, mostly in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/system/syslogs_provider.h ('k') | chrome/browser/chromeos/version_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/system/syslogs_provider.cc
diff --git a/chrome/browser/chromeos/system/syslogs_provider.cc b/chrome/browser/chromeos/system/syslogs_provider.cc
index 271f42a320852cad9b32239487961a7f0ad8b4a9..48352b0752964df858187ea6397e3c76de95fb70 100644
--- a/chrome/browser/chromeos/system/syslogs_provider.cc
+++ b/chrome/browser/chromeos/system/syslogs_provider.cc
@@ -175,7 +175,7 @@ class SyslogsProviderImpl : public SyslogsProvider {
bool compress_logs,
SyslogsContext context,
CancelableRequestConsumerBase* consumer,
- ReadCompleteCallback* callback);
+ const ReadCompleteCallback& callback);
// Reads system logs, compresses content if requested.
// Called from FILE thread.
@@ -208,7 +208,7 @@ CancelableRequestProvider::Handle SyslogsProviderImpl::RequestSyslogs(
bool compress_logs,
SyslogsContext context,
CancelableRequestConsumerBase* consumer,
- ReadCompleteCallback* callback) {
+ const ReadCompleteCallback& callback) {
// Register the callback request.
scoped_refptr<CancelableRequest<ReadCompleteCallback> > request(
new CancelableRequest<ReadCompleteCallback>(callback));
@@ -285,8 +285,7 @@ class SyslogsMemoryHandler : public MemoryDetails {
}
(*logs_)["mem_usage"] = mem_string;
// This will call the callback on the calling thread.
- request_->ForwardResult(
- Tuple2<LogDictionaryType*, std::string*>(logs_, zip_content_));
+ request_->ForwardResult(logs_, zip_content_);
}
private:
« no previous file with comments | « chrome/browser/chromeos/system/syslogs_provider.h ('k') | chrome/browser/chromeos/version_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698