Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: chrome/browser/ui/webui/net_internals_ui.cc

Issue 8113025: base::Bind: More converts, mostly in WebUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/net_internals_ui.h" 5 #include "chrome/browser/ui/webui/net_internals_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/base64.h" 13 #include "base/base64.h"
14 #include "base/bind.h"
15 #include "base/bind_helpers.h"
14 #include "base/command_line.h" 16 #include "base/command_line.h"
15 #include "base/memory/singleton.h" 17 #include "base/memory/singleton.h"
16 #include "base/message_loop.h" 18 #include "base/message_loop.h"
17 #include "base/path_service.h" 19 #include "base/path_service.h"
18 #include "base/string_number_conversions.h" 20 #include "base/string_number_conversions.h"
19 #include "base/string_piece.h" 21 #include "base/string_piece.h"
20 #include "base/string_split.h" 22 #include "base/string_split.h"
21 #include "base/string_util.h" 23 #include "base/string_util.h"
22 #include "base/utf_string_conversions.h" 24 #include "base/utf_string_conversions.h"
23 #include "base/values.h" 25 #include "base/values.h"
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 } 490 }
489 491
490 WebUIMessageHandler* result = WebUIMessageHandler::Attach(web_ui); 492 WebUIMessageHandler* result = WebUIMessageHandler::Attach(web_ui);
491 return result; 493 return result;
492 } 494 }
493 495
494 void NetInternalsMessageHandler::RegisterMessages() { 496 void NetInternalsMessageHandler::RegisterMessages() {
495 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 497 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
496 web_ui_->RegisterMessageCallback( 498 web_ui_->RegisterMessageCallback(
497 "notifyReady", 499 "notifyReady",
498 NewCallback(this, &NetInternalsMessageHandler::OnRendererReady)); 500 base::Bind(&NetInternalsMessageHandler::OnRendererReady,
501 base::Unretained(this)));
499 web_ui_->RegisterMessageCallback( 502 web_ui_->RegisterMessageCallback(
500 "getProxySettings", 503 "getProxySettings",
501 proxy_->CreateCallback(&IOThreadImpl::OnGetProxySettings)); 504 proxy_->CreateCallback(&IOThreadImpl::OnGetProxySettings));
502 web_ui_->RegisterMessageCallback( 505 web_ui_->RegisterMessageCallback(
503 "reloadProxySettings", 506 "reloadProxySettings",
504 proxy_->CreateCallback(&IOThreadImpl::OnReloadProxySettings)); 507 proxy_->CreateCallback(&IOThreadImpl::OnReloadProxySettings));
505 web_ui_->RegisterMessageCallback( 508 web_ui_->RegisterMessageCallback(
506 "getBadProxies", 509 "getBadProxies",
507 proxy_->CreateCallback(&IOThreadImpl::OnGetBadProxies)); 510 proxy_->CreateCallback(&IOThreadImpl::OnGetBadProxies));
508 web_ui_->RegisterMessageCallback( 511 web_ui_->RegisterMessageCallback(
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 proxy_->CreateCallback( 555 proxy_->CreateCallback(
553 &IOThreadImpl::OnGetSpdyAlternateProtocolMappings)); 556 &IOThreadImpl::OnGetSpdyAlternateProtocolMappings));
554 #ifdef OS_WIN 557 #ifdef OS_WIN
555 web_ui_->RegisterMessageCallback( 558 web_ui_->RegisterMessageCallback(
556 "getServiceProviders", 559 "getServiceProviders",
557 proxy_->CreateCallback(&IOThreadImpl::OnGetServiceProviders)); 560 proxy_->CreateCallback(&IOThreadImpl::OnGetServiceProviders));
558 #endif 561 #endif
559 #ifdef OS_CHROMEOS 562 #ifdef OS_CHROMEOS
560 web_ui_->RegisterMessageCallback( 563 web_ui_->RegisterMessageCallback(
561 "refreshSystemLogs", 564 "refreshSystemLogs",
562 NewCallback(this, &NetInternalsMessageHandler::OnRefreshSystemLogs)); 565 base::Bind(&NetInternalsMessageHandler::OnRefreshSystemLogs,
566 base::Unretained(this)));
563 web_ui_->RegisterMessageCallback( 567 web_ui_->RegisterMessageCallback(
564 "getSystemLog", 568 "getSystemLog",
565 NewCallback(this, &NetInternalsMessageHandler::OnGetSystemLog)); 569 base::Bind(&NetInternalsMessageHandler::OnGetSystemLog,
570 base::Unretained(this)));
566 #endif 571 #endif
567 web_ui_->RegisterMessageCallback( 572 web_ui_->RegisterMessageCallback(
568 "setLogLevel", 573 "setLogLevel",
569 proxy_->CreateCallback(&IOThreadImpl::OnSetLogLevel)); 574 proxy_->CreateCallback(&IOThreadImpl::OnSetLogLevel));
570 web_ui_->RegisterMessageCallback( 575 web_ui_->RegisterMessageCallback(
571 "enableHttpThrottling", 576 "enableHttpThrottling",
572 NewCallback(this, &NetInternalsMessageHandler::OnEnableHttpThrottling)); 577 base::Bind(&NetInternalsMessageHandler::OnEnableHttpThrottling,
578 base::Unretained(this)));
573 web_ui_->RegisterMessageCallback( 579 web_ui_->RegisterMessageCallback(
574 "getPrerenderInfo", 580 "getPrerenderInfo",
575 NewCallback(this, &NetInternalsMessageHandler::OnGetPrerenderInfo)); 581 base::Bind(&NetInternalsMessageHandler::OnGetPrerenderInfo,
582 base::Unretained(this)));
576 } 583 }
577 584
578 void NetInternalsMessageHandler::SendJavascriptCommand( 585 void NetInternalsMessageHandler::SendJavascriptCommand(
579 const std::wstring& command, 586 const std::wstring& command,
580 Value* arg) { 587 Value* arg) {
581 scoped_ptr<Value> command_value( 588 scoped_ptr<Value> command_value(
582 Value::CreateStringValue(WideToASCII(command))); 589 Value::CreateStringValue(WideToASCII(command)));
583 scoped_ptr<Value> value(arg); 590 scoped_ptr<Value> value(arg);
584 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 591 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
585 if (value.get()) { 592 if (value.get()) {
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 } 708 }
702 709
703 void NetInternalsMessageHandler::SystemLogsGetter::LoadSystemLogs() { 710 void NetInternalsMessageHandler::SystemLogsGetter::LoadSystemLogs() {
704 if (logs_requested_ || !syslogs_provider_) 711 if (logs_requested_ || !syslogs_provider_)
705 return; 712 return;
706 logs_requested_ = true; 713 logs_requested_ = true;
707 syslogs_request_id_ = syslogs_provider_->RequestSyslogs( 714 syslogs_request_id_ = syslogs_provider_->RequestSyslogs(
708 false, // compress logs. 715 false, // compress logs.
709 chromeos::system::SyslogsProvider::SYSLOGS_NETWORK, 716 chromeos::system::SyslogsProvider::SYSLOGS_NETWORK,
710 &consumer_, 717 &consumer_,
711 NewCallback( 718 base::Bind(
712 this, 719 &NetInternalsMessageHandler::SystemLogsGetter::OnSystemLogsLoaded,
713 &NetInternalsMessageHandler::SystemLogsGetter::OnSystemLogsLoaded)); 720 base::Unretained(this)));
714 } 721 }
715 722
716 void NetInternalsMessageHandler::SystemLogsGetter::OnSystemLogsLoaded( 723 void NetInternalsMessageHandler::SystemLogsGetter::OnSystemLogsLoaded(
717 chromeos::system::LogDictionaryType* sys_info, 724 chromeos::system::LogDictionaryType* sys_info,
718 std::string* ignored_content) { 725 std::string* ignored_content) {
719 DCHECK(!ignored_content); 726 DCHECK(!ignored_content);
720 logs_.reset(sys_info); 727 logs_.reset(sys_info);
721 logs_received_ = true; 728 logs_received_ = true;
722 for (std::list<SystemLogRequest>::iterator request_it = requests_.begin(); 729 for (std::list<SystemLogRequest>::iterator request_it = requests_.begin();
723 request_it != requests_.end(); 730 request_it != requests_.end();
(...skipping 832 matching lines...) Expand 10 before | Expand all | Expand 10 after
1556 return constants_dict; 1563 return constants_dict;
1557 } 1564 }
1558 1565
1559 NetInternalsUI::NetInternalsUI(TabContents* contents) : ChromeWebUI(contents) { 1566 NetInternalsUI::NetInternalsUI(TabContents* contents) : ChromeWebUI(contents) {
1560 AddMessageHandler((new NetInternalsMessageHandler())->Attach(this)); 1567 AddMessageHandler((new NetInternalsMessageHandler())->Attach(this));
1561 1568
1562 // Set up the chrome://net-internals/ source. 1569 // Set up the chrome://net-internals/ source.
1563 GetProfile()->GetChromeURLDataManager()->AddDataSource( 1570 GetProfile()->GetChromeURLDataManager()->AddDataSource(
1564 CreateNetInternalsHTMLSource()); 1571 CreateNetInternalsHTMLSource());
1565 } 1572 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/chromeos/system_info_ui.cc ('k') | chrome/browser/ui/webui/options/chromeos/about_page_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698