Check enumerability of array indices correctly in propertyIsEnumerable.

Check enumerability of array indices correctly in propertyIsEnumerable.

Fix issue 1692.

BUG=v8:1692
TEST=mjsunit/regress/regress-1692

Committed: http://code.google.com/p/v8/source/detail?r=9503

[Rico, 2011-10-03 09:07:59]

LGTM

http://codereview.chromium.org/8113001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8113001/diff/1/src/runtime.cc#newcode4711
src/runtime.cc:4711: return isolate->heap()->false_value();
Could we add a test to exercise this code path

http://codereview.chromium.org/8113001/diff/1/src/runtime.cc#newcode4714
src/runtime.cc:4714: return isolate->heap()->true_value();
Same as above

[Lasse Reichstein, 2011-10-03 09:14:43]

http://codereview.chromium.org/8113001/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/8113001/diff/1/src/runtime.cc#newcode4711
src/runtime.cc:4711: return isolate->heap()->false_value();
Will test both.

http://codereview.chromium.org/8113001/diff/1/src/runtime.cc#newcode4714
src/runtime.cc:4714: return isolate->heap()->true_value();
Will test fast elements. Interceptor will require a C-test, but this isn't a
test of HasLocalElement, so we'll assume it works correctly.

[arv (Not doing code reviews), 2011-10-03 16:40:29]

http://codereview.chromium.org/8113001/diff/4001/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-1692.js (right):

http://codereview.chromium.org/8113001/diff/4001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-1692.js:89: assertTrue(o.propertyIsEnumerable(3));
This might be worth testing too

var 0 = [0, 1, , 3, 4];
assertFalse(o.propertyIsEnumerable(2));