Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: src/x64/stub-cache-x64.cc

Issue 8111006: Allow new-space JSFunction objects as constant-function properties. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/x64/macro-assembler-x64.cc ('K') | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/stub-cache-x64.cc
===================================================================
--- src/x64/stub-cache-x64.cc (revision 9574)
+++ src/x64/stub-cache-x64.cc (working copy)
@@ -421,7 +421,7 @@
// -----------------------------------
// Get the function and setup the context.
JSFunction* function = optimization.constant_function();
- __ Move(rdi, Handle<JSFunction>(function));
+ __ LoadHeapObject(rdi, Handle<JSFunction>(function));
__ movq(rsi, FieldOperand(rdi, JSFunction::kContextOffset));
// Pass the additional arguments.
@@ -1087,7 +1087,7 @@
Register scratch1,
Register scratch2,
Register scratch3,
- Object* value,
+ JSFunction* value,
String* name,
Label* miss) {
// Check that the receiver isn't a smi.
@@ -1098,7 +1098,7 @@
scratch1, scratch2, scratch3, name, miss);
// Return the constant value.
- __ Move(rax, Handle<Object>(value));
+ __ LoadHeapObject(rax, Handle<JSFunction>(value));
__ ret(0);
}
@@ -2729,7 +2729,7 @@
MaybeObject* LoadStubCompiler::CompileLoadConstant(JSObject* object,
JSObject* holder,
- Object* value,
+ JSFunction* value,
String* name) {
// ----------- S t a t e -------------
// -- rax : receiver
@@ -2898,7 +2898,7 @@
MaybeObject* KeyedLoadStubCompiler::CompileLoadConstant(String* name,
JSObject* receiver,
JSObject* holder,
- Object* value) {
+ JSFunction* value) {
// ----------- S t a t e -------------
// -- rax : key
// -- rdx : receiver
« src/x64/macro-assembler-x64.cc ('K') | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698