Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 8111006: Allow new-space JSFunction objects as constant-function properties. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/stub-cache-ia32.cc
===================================================================
--- src/ia32/stub-cache-ia32.cc (revision 9574)
+++ src/ia32/stub-cache-ia32.cc (working copy)
@@ -430,7 +430,7 @@
// -----------------------------------
// Get the function and setup the context.
JSFunction* function = optimization.constant_function();
- __ mov(edi, Immediate(Handle<JSFunction>(function)));
+ __ LoadHeapObject(edi, Handle<JSFunction>(function));
__ mov(esi, FieldOperand(edi, JSFunction::kContextOffset));
// Pass the additional arguments.
@@ -1112,7 +1112,7 @@
Register scratch1,
Register scratch2,
Register scratch3,
- Object* value,
+ JSFunction* value,
String* name,
Label* miss) {
// Check that the receiver isn't a smi.
@@ -1122,8 +1122,7 @@
CheckPrototypes(object, receiver, holder,
scratch1, scratch2, scratch3, name, miss);
- // Return the constant value.
- __ mov(eax, Handle<Object>(value));
+ __ LoadHeapObject(eax, Handle<JSFunction>(value));
__ ret(0);
}
@@ -2879,7 +2878,7 @@
MaybeObject* LoadStubCompiler::CompileLoadConstant(JSObject* object,
JSObject* holder,
- Object* value,
+ JSFunction* value,
String* name) {
// ----------- S t a t e -------------
// -- eax : receiver
@@ -3052,7 +3051,7 @@
MaybeObject* KeyedLoadStubCompiler::CompileLoadConstant(String* name,
JSObject* receiver,
JSObject* holder,
- Object* value) {
+ JSFunction* value) {
// ----------- S t a t e -------------
// -- eax : key
// -- edx : receiver

Powered by Google App Engine
This is Rietveld 408576698