chrome/browser/cocoa/extension_installed_bubble_controller.mm - Issue 811002: Merge 41114 - [Mac] More progress towards resizing the Browser Actions contai...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/extension_installed_bubble_controller.mm

Issue 811002: Merge 41114 - [Mac] More progress towards resizing the Browser Actions contai... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/342/src/

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/cocoa/extensions/browser_actions_container_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/extension_installed_bubble_controller.mm

===================================================================

--- chrome/browser/cocoa/extension_installed_bubble_controller.mm (revision 41123)

+++ chrome/browser/cocoa/extension_installed_bubble_controller.mm (working copy)

@@ -174,9 +174,14 @@

NSRect boundsRect = [[[button window] contentView]

convertRect:[button frame]

fromView:[button superview]];

- arrowPoint =

- NSMakePoint(NSMinX(boundsRect) + NSWidth([button frame]) / 2,

- NSMinY(boundsRect));

+ CGFloat xPos = NSMinX(boundsRect) + NSWidth([button frame]) / 2;

+ // If the button is hidden, display the button at the edge of the Browser

+ // Actions container.

+ // TODO(andybons): Make it point to the chevron once it's implemented.

+ if ([button alphaValue] == 0.0)

+ xPos = NSMaxX([[button superview] frame]);

+ arrowPoint = NSMakePoint(xPos, NSMinY(boundsRect));

break;

}

case extension_installed_bubble::kPageAction: {