Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 8110003: Show avatar menu from NTP4 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_window.h » ('j') | chrome/browser/ui/browser_window.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 00e92414bf80a3c127507657b145ce9f050d002f..ef0d19c0d4343802ae96a90e2d6ffa67c56f114d 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -150,7 +150,8 @@ cr.define('ntp4', function() {
chrome.send('initializeLogin');
$('login-container').addEventListener('click', function() {
- chrome.send('loginContainerClicked');
+ var rect = $('login-container').getBoundingClientRect();
+ chrome.send('loginContainerClicked', [rect.right, rect.bottom]);
arv (Not doing code reviews) 2011/10/03 17:06:09 Don't you want to send the entire rect here? RTL a
sail 2011/10/03 18:46:03 Done. I've also filed http://crbug.com/98884 about
});
// Prevent touch events from triggering any sort of native scrolling
« no previous file with comments | « no previous file | chrome/browser/ui/browser_window.h » ('j') | chrome/browser/ui/browser_window.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698