Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 8110003: Show avatar menu from NTP4 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/ui/bookmarks/bookmark_bar.h" 9 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
10 #include "chrome/common/content_settings_types.h" 10 #include "chrome/common/content_settings_types.h"
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 // Invoked when the preferred size of the contents in current tab has been 346 // Invoked when the preferred size of the contents in current tab has been
347 // changed. We might choose to update the window size to accomodate this 347 // changed. We might choose to update the window size to accomodate this
348 // change. 348 // change.
349 // Note that this won't be fired if we change tabs. 349 // Note that this won't be fired if we change tabs.
350 virtual void UpdatePreferredSize(TabContents* tab_contents, 350 virtual void UpdatePreferredSize(TabContents* tab_contents,
351 const gfx::Size& pref_size) {} 351 const gfx::Size& pref_size) {}
352 352
353 // Construct a BrowserWindow implementation for the specified |browser|. 353 // Construct a BrowserWindow implementation for the specified |browser|.
354 static BrowserWindow* CreateBrowserWindow(Browser* browser); 354 static BrowserWindow* CreateBrowserWindow(Browser* browser);
355 355
356 // Shows the avatar bubble at the given position inside |tab_contents|.
Robert Sesek 2011/10/03 14:55:57 In what coordinate system is the point?
sail 2011/10/03 18:46:03 Should be in tab_content's coordinate system. Adde
357 virtual void ShowAvatarBubble(TabContents* tab_contents, int x, int y) = 0;
Robert Sesek 2011/10/03 14:55:57 Use a gfx::Point?
sail 2011/10/03 18:46:03 Changed to gfx::Rect.
Elliot Glaysher 2011/10/03 19:26:46 Why a Rect? The bubble size will depend on platfor
sail 2011/10/03 19:28:35 The bubble position depends on the width and heigh
358
356 protected: 359 protected:
357 friend class BrowserList; 360 friend class BrowserList;
358 friend class BrowserView; 361 friend class BrowserView;
359 virtual void DestroyBrowser() = 0; 362 virtual void DestroyBrowser() = 0;
360 }; 363 };
361 364
362 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS) 365 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
363 class BookmarkBarView; 366 class BookmarkBarView;
364 class LocationBarView; 367 class LocationBarView;
365 368
(...skipping 21 matching lines...) Expand all
387 390
388 // Returns the ToolbarView. 391 // Returns the ToolbarView.
389 virtual ToolbarView* GetToolbarView() const = 0; 392 virtual ToolbarView* GetToolbarView() const = 0;
390 #endif 393 #endif
391 394
392 protected: 395 protected:
393 virtual ~BrowserWindowTesting() {} 396 virtual ~BrowserWindowTesting() {}
394 }; 397 };
395 398
396 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 399 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698