Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 8109001: Fix compilation when use_aura is turned ON. (Closed)

Created:
9 years, 2 months ago by vamshi
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix compilation when use_aura is turned ON. BUG=none TEST=none Patch by vamshi@motorola.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vamshi
9 years, 2 months ago (2011-10-02 05:50:17 UTC) #1
vamshi
Following error is seen when use_aura is turned ON: Updating projects from gyp files... Traceback ...
9 years, 2 months ago (2011-10-02 05:51:09 UTC) #2
jam
lgtm
9 years, 2 months ago (2011-10-03 02:50:44 UTC) #3
vamshi
On 2011/10/03 02:50:44, John Abd-El-Malek wrote: > lgtm Thanks. I am new to Chromium, should ...
9 years, 2 months ago (2011-10-03 04:33:30 UTC) #4
jam
yep. if it doesn't let you because you're not a committer, let me know and ...
9 years, 2 months ago (2011-10-03 05:33:52 UTC) #5
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/vamshi@motorola.com/8109001/1
9 years, 2 months ago (2011-10-03 05:48:19 UTC) #6
vamshi
I thinks it's working. On 2011/10/03 05:33:52, John Abd-El-Malek wrote: > yep. if it doesn't ...
9 years, 2 months ago (2011-10-03 05:49:13 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-03 07:21:52 UTC) #8
Change committed as 103688

Powered by Google App Engine
This is Rietveld 408576698