redesign and reimplement proxy config service and tracker, revise proxy ui on cros

chrome/browser/ui/webui/options/core_options_handler.h

Index: chrome/browser/ui/webui/options/core_options_handler.h
===================================================================
--- chrome/browser/ui/webui/options/core_options_handler.h	(revision 106059)
+++ chrome/browser/ui/webui/options/core_options_handler.h	(working copy)
@@ -12,6 +12,7 @@
 #include "base/values.h"
 #include "chrome/browser/plugin_data_remover_helper.h"
 #include "chrome/browser/prefs/pref_change_registrar.h"
+#include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 
 // Core options UI handler.
@@ -66,8 +67,22 @@
   void ProcessUserMetric(const Value* value,
                          const std::string& metric);
 
+  // Notifies registered JS callbacks on change in |pref_name| preference.
+  // |controlling_pref_name| controls if |pref_name| is managed by
+  // policy/extension; empty |controlling_pref_name| indicates no other pref is
+  // controlling |pref_name|.
+  void NotifyPrefChanged(const std::string& pref_name,
+                         const std::string& controlling_pref_name);
+
+  // Creates dictioary value for |pref|, |controlling_pref| controls if |pref|

[Mattias Nissler (ping if slow), 2011/10/19 19:27:36]

s/dictioary/dictionary/

[kuan, 2011/10/20 00:41:11]

Done.

+  // is managed by policy/managed; NULL indicates no ordher pref is controlling

[Mattias Nissler (ping if slow), 2011/10/19 19:27:36]

s/ordher/other/

[kuan, 2011/10/20 00:41:11]

Done.

+  // |pref|.
+  DictionaryValue* CreateValueForPref(const PrefService::Preference* pref,
+      const PrefService::Preference* controlling_pref);

[Mattias Nissler (ping if slow), 2011/10/19 19:27:36]

parameters should be aligned.

[kuan, 2011/10/20 00:41:11]

Done.

+
   typedef std::multimap<std::string, std::wstring> PreferenceCallbackMap;
   PreferenceCallbackMap pref_callback_map_;
+
  private:
   // Type of preference value received from the page. This doesn't map 1:1 to
   // Value::Type, since a TYPE_STRING can require custom processing.
@@ -122,8 +137,6 @@
 
   void UpdateClearPluginLSOData();
 
-  void NotifyPrefChanged(const std::string* pref_name);
-
   OptionsPageUIHandlerHost* handlers_host_;
   PrefChangeRegistrar registrar_;