Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 8102019: redesign and reimplement proxy config service and tracker, revise proxy ui on cros (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider.cc
===================================================================
--- chrome/browser/automation/testing_automation_provider.cc (revision 106059)
+++ chrome/browser/automation/testing_automation_provider.cc (working copy)
@@ -2341,10 +2341,6 @@
handler_map["NetworkScan"] = &TestingAutomationProvider::NetworkScan;
handler_map["ToggleNetworkDevice"] =
&TestingAutomationProvider::ToggleNetworkDevice;
- handler_map["GetProxySettings"] =
- &TestingAutomationProvider::GetProxySettings;
- handler_map["SetProxySettings"] =
- &TestingAutomationProvider::SetProxySettings;
handler_map["ConnectToCellularNetwork"] =
&TestingAutomationProvider::ConnectToCellularNetwork;
handler_map["DisconnectFromCellularNetwork"] =
@@ -2553,6 +2549,10 @@
browser_handler_map["CaptureProfilePhoto"] =
&TestingAutomationProvider::CaptureProfilePhoto;
browser_handler_map["GetTimeInfo"] = &TestingAutomationProvider::GetTimeInfo;
+ browser_handler_map["GetProxySettings"] =
+ &TestingAutomationProvider::GetProxySettings;
+ browser_handler_map["SetProxySettings"] =
+ &TestingAutomationProvider::SetProxySettings;
Mattias Nissler (ping if slow) 2011/10/19 19:27:36 Why did you move this down? It seems that previous
kuan 2011/10/20 00:41:11 dave, who wrote this code and reviewed this change
Mattias Nissler (ping if slow) 2011/10/24 10:18:28 Ah, I had missed the handler_map -> browser_handle
#endif // defined(OS_CHROMEOS)
// Look for command in handlers that take a Browser handle.

Powered by Google App Engine
This is Rietveld 408576698