redesign and reimplement proxy config service and tracker, revise proxy ui on cros

chrome/browser/chromeos/proxy_cros_settings_provider.h

Index: chrome/browser/chromeos/proxy_cros_settings_provider.h
===================================================================
--- chrome/browser/chromeos/proxy_cros_settings_provider.h	(revision 103881)
+++ chrome/browser/chromeos/proxy_cros_settings_provider.h	(working copy)
@@ -20,6 +20,10 @@
   virtual bool Get(const std::string& path, Value** out_value) const OVERRIDE;
   virtual bool HandlesSetting(const std::string& path) const OVERRIDE;
 
+  // Set the current user profile whose prefs proxy config, if available, will
+  // be disapledy and possibly edited on.

[Mattias Nissler (ping if slow), 2011/10/07 13:32:10]

s/disapled/displayed/

[kuan, 2011/10/18 16:25:35]

function is removed.

+  virtual void SetCurrentUserProfile(Profile* profile);

[Mattias Nissler (ping if slow), 2011/10/07 13:32:10]

This is asking for trouble once multi-profile comes around and two different
profiles try and show proxy settings. Since CrosSettingsProvider is not
profile-specific, I think it's actually wrong to push proxy config through it.
It seems the way to go is convert ProxyCrosSettingsProvider into a
CoreOptionsHandler subclass that talks directly to chromeos::ProxyConfigService.
The options handler is bound to a webui, thus has a profile available.

[kuan, 2011/10/18 16:25:35]

i've modified constructor to take in Profile parameter.

+
   // Set the current network whose proxy settings will be displayed and possibly
   // edited on.
   void SetCurrentNetwork(const std::string& network);
@@ -32,9 +36,6 @@
   // MakeActiveNetworkCurrent.
   const std::string& GetCurrentNetworkName() const;
 
-  // Returns true if user has selected to use shared proxies.
-  bool IsUsingSharedProxies() const;
-
  private:
   // CrosSettingsProvider implementation.
   virtual void DoSet(const std::string& path, Value* value) OVERRIDE;