redesign and reimplement proxy config service and tracker, revise proxy ui on cros

chrome/browser/profiles/profile.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class gathers state related to a single user profile.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "chrome/browser/net/preconnect.h" // TODO: remove this.
 #include "chrome/common/extensions/extension_constants.h"
 #include "content/browser/browser_context.h"
 
 namespace base {
 class Time;
 }
 
 namespace chromeos {
 class LibCrosServiceLibraryImpl;
 class ResetDefaultProxyConfigServiceTask;
 }
 
+#if defined(OS_CHROMEOS)
+namespace chromeos {
+class ProxyConfigServiceImpl;
+}
+#endif  // defined(OS_CHROMEOS)
+
 namespace fileapi {
 class FileSystemContext;
 class SandboxedFileSystemContext;
 }
 
 namespace history {
 class TopSites;
 class ShortcutsBackend;
 }
 
@@ skipping 50 matching lines @@
 class WebUI;
 
 #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && defined(OS_POSIX)
 // Local profile ids are used to associate resources stored outside the profile
 // directory, like saved passwords in GNOME Keyring / KWallet, with a profile.
 // With high probability, they are unique on the local machine. They are almost
 // certainly not unique globally, by design. Do not send them over the network.
 typedef int LocalProfileId;
 #endif
 
+#if defined(OS_CHROMEOS)
+typedef chromeos::ProxyConfigServiceImpl PrefProxyConfigTrackerType;
+#else
+typedef PrefProxyConfigTracker PrefProxyConfigTrackerType;
+#endif  // defined(OS_CHROMEOS)

[Mattias Nissler (ping if slow), 2011/10/24 10:18:28]

I'm wondering whether we might even want to go a step further and put the
typedef and forward declaration into pref_proxy_config_service.h?

[kuan, 2011/10/25 02:01:54]

Done.

+
 class Profile : public content::BrowserContext {
  public:
   // Profile services are accessed with the following parameter. This parameter
   // defines what the caller plans to do with the service.
   // The caller is responsible for not performing any operation that would
   // result in persistent implicit records while using an OffTheRecord profile.
   // This flag allows the profile to perform an additional check.
   //
   // It also gives us an opportunity to perform further checks in the future. We
   // could, for example, return an history service that only allow some specific
@@ skipping 364 matching lines @@
 
   // Creates ChromeOS's EnterpriseExtensionListener.
   virtual void SetupChromeOSEnterpriseExtensionObserver() = 0;
 
   // Initializes Chrome OS's preferences.
   virtual void InitChromeOSPreferences() = 0;
 #endif  // defined(OS_CHROMEOS)
 
   // Returns the helper object that provides the proxy configuration service
   // access to the the proxy configuration possibly defined by preferences.
-  virtual PrefProxyConfigTracker* GetProxyConfigTracker() = 0;
+  virtual PrefProxyConfigTrackerType* GetProxyConfigTracker() = 0;
 
   // Returns the Predictor object used for dns prefetch.
   virtual chrome_browser_net::Predictor* GetNetworkPredictor() = 0;
 
   // Deletes all network related data since |time|. It deletes transport
   // security state since |time| and it also delete HttpServerProperties data.
   // The implementation is free to run this on a background thread, so when this
   // method returns data is not guaranteed to be deleted.
   virtual void ClearNetworkingHistorySince(base::Time time) = 0;
 
@@ skipping 71 matching lines @@
 struct hash<Profile*> {
   std::size_t operator()(Profile* const& p) const {
     return reinterpret_cast<std::size_t>(p);
   }
 };
 
 }  // namespace __gnu_cxx
 #endif
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_H_