Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: ppapi/native_client/tests/ppapi_simple_tests/file.cc

Issue 8102006: Workaround a problem where clang and gcc behavior wrt the creation (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/tests/ppapi_simple_tests/file1.stdin » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/ppapi_simple_tests/file.cc
===================================================================
--- ppapi/native_client/tests/ppapi_simple_tests/file.cc (revision 102105)
+++ ppapi/native_client/tests/ppapi_simple_tests/file.cc (working copy)
@@ -144,7 +144,7 @@
}
void OpenFile() {
- file_ref_ = new pp::FileRef(response_info_->GetBodyAsFileRef());
+ file_ref_ = new pp::FileRef(loader_.GetResponseInfo().GetBodyAsFileRef());
CHECK(!file_ref_->is_null());
file_io_ = new pp::FileIO(instance_);
@@ -183,10 +183,9 @@
static void OpenURLCompleteCallback(void* thiz, int32_t result) {
ReaderStreamAsFile* reader = static_cast<ReaderStreamAsFile*>(thiz);
- reader->response_info_ =
- new pp::URLResponseInfo(reader->loader_.GetResponseInfo());
- CHECK(!reader->response_info_->is_null());
- int32_t status_code = reader->response_info_->GetStatusCode();
+ pp::URLResponseInfo response_info(reader->loader_.GetResponseInfo());
+ CHECK(!response_info.is_null());
+ int32_t status_code = response_info.GetStatusCode();
if (status_code != 200) {
reader->Message("Error: OpenURLCompleteCallback unexpected status code");
return;
« no previous file with comments | « no previous file | ppapi/native_client/tests/ppapi_simple_tests/file1.stdin » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698