Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

Issue 8098017: Make content_shell handle renderers going away. I've made TabContents call TabContentsView::OnTab... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc
===================================================================
--- chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (revision 103561)
+++ chrome/browser/ui/tab_contents/tab_contents_wrapper.cc (working copy)
@@ -12,7 +12,6 @@
#include "chrome/browser/autofill/autofill_manager.h"
#include "chrome/browser/automation/automation_tab_helper.h"
#include "chrome/browser/browser_process.h"
-#include "chrome/browser/browser_shutdown.h"
#include "chrome/browser/content_settings/tab_specific_content_settings.h"
#include "chrome/browser/download/download_request_limiter_observer.h"
#include "chrome/browser/extensions/extension_tab_helper.h"
@@ -546,17 +545,6 @@
UpdateAlternateErrorPageURL(render_view_host);
}
-void TabContentsWrapper::RenderViewGone() {
- // Tell the view that we've crashed so it can prepare the sad tab page.
- // Only do this if we're not in browser shutdown, so that TabContents
- // objects that are not in a browser (e.g., HTML dialogs) and thus are
- // visible do not flash a sad tab page.
- if (browser_shutdown::GetShutdownType() == browser_shutdown::NOT_VALID) {
- tab_contents()->view()->OnTabCrashed(
- tab_contents()->crashed_status(), tab_contents()->crashed_error_code());
- }
-}
-
void TabContentsWrapper::DidBecomeSelected() {
WebCacheManager::GetInstance()->ObserveActivity(
tab_contents()->GetRenderProcessHost()->id());
« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents_wrapper.h ('k') | chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698