Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 8098001: Fix a crash in the renderer process which occurs in the PPAPI host code due to the underlying plugin (Closed)

Created:
9 years, 2 months ago by ananta
Modified:
9 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix a crash in the renderer process which occurs in the PPAPI host code due to the underlying plugin object getting destroyed in the context of an incoming ExecuteScript call while the renderer is waiting for an javascript function call on the plugin object to return. We need to grab a reference on the plugin module in the dispatcher code and in the plugin object as there are two crashes which occur here 1. When the dispatcher send is about to return from the Send call and it tries to unmarshal the return values. 2. The other crash is in the wrapper class Invoke function where we crash similarly. Fixes bug http://code.google.com/p/flapper/issues/detail?id=77 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M ppapi/proxy/host_dispatcher.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/plugin_object.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 2 months ago (2011-09-30 16:50:27 UTC) #1
piman
9 years, 2 months ago (2011-09-30 22:23:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698