Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: content/renderer/render_view.cc

Issue 8095007: Defer loading of audio/video tags while prerendering. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view.cc
diff --git a/content/renderer/render_view.cc b/content/renderer/render_view.cc
index 02d3cf26520278a392abfc310a10c485d47cd1d3..3800c6b11405421794af88872d73b3d2b7be54bb 100644
--- a/content/renderer/render_view.cc
+++ b/content/renderer/render_view.cc
@@ -1909,12 +1909,21 @@ WebMediaPlayer* RenderView::createMediaPlayer(
collection->AddVideoRenderer(renderer);
video_renderer = renderer;
- scoped_ptr<webkit_glue::WebMediaPlayerImpl> result(
- new webkit_glue::WebMediaPlayerImpl(client,
- collection.release(),
- message_loop_factory.release(),
- media_stream_impl_.get(),
- new RenderMediaLog()));
+ scoped_ptr<webkit_glue::WebMediaPlayerImpl> result;
+ if (content::GetContentClient()->renderer()
+ ->ShouldOverrideCreateWebMediaPlayer(this)) {
+ webkit_glue::WebMediaPlayerImpl* result_ptr;
+ content::GetContentClient()->renderer()->OverrideCreateWebMediaPlayer(
+ this, client, collection.release(), message_loop_factory.release(),
+ media_stream_impl_.get(), new RenderMediaLog(), &result_ptr);
+ result.reset(result_ptr);
+ } else {
+ result.reset(new webkit_glue::WebMediaPlayerImpl(client,
+ collection.release(), message_loop_factory.release(),
+ media_stream_impl_.get(), new RenderMediaLog()));
+ }
+ DCHECK(result.get());
scherkus (not reviewing) 2011/10/03 18:19:45 should'nt this DCHECK go inside the ShouldOverride
Shishir 2011/10/04 23:02:39 Done.
+
if (!result->Initialize(frame,
cmd_line->HasSwitch(switches::kSimpleDataSource),
video_renderer)) {
« content/renderer/content_renderer_client.h ('K') | « content/renderer/content_renderer_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698