chrome/test/data/prerender/prerender_html5_video_script.html - Issue 8095007: Defer loading of audio/video tags while prerendering.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_html5_video_script.html

Issue 8095007: Defer loading of audio/video tags while prerendering. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Addressing Andrew's comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/prerender/prerender_html5_video.html ('K') | « chrome/test/data/prerender/prerender_html5_video.html ('k') | content/public/renderer/content_renderer_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <!--	2 <!--

3 This test checks that prerender is cancelled when an video starts playing	3 This test checks that prerender is cancelled when an video starts playing
	scherkus (not reviewing) 2011/10/05 20:21:58 ditto on updating docs ditto on updating docs Shishir 2011/10/20 21:20:39 Done. Show quoted text On 2011/10/05 20:21:58, scherkus wrote: > ditto on updating docs Done.
4 through javascript.	4 through javascript.

5 -->	5 -->

6 <head>	6 <head>

7 <title>Prerender cancellation for HTML5 video.</title>	7 <title>Prerender cancellation for HTML5 video.</title>

	8

	9 <script>

	10 function DidPrerenderPass() {

	11 return true;

	12 }

	13 function DidDisplayPass() {

	14 return true;

	15 }

	16 </script>

8 </head>	17 </head>

9 <body>	18 <body>

10 <div id="vid">	19 <div id="vid">

11 </div>	20 </div>

12	21

13 <script>	22 <script>

14 var videoTag = document.createElement("video");	23 var videoTag = document.createElement("video");

15 videoTag.src = "nonexistant.mp4";	24 videoTag.src = "nonexistant.mp4";

16 var element = document.getElementById("vid");	25 var element = document.getElementById("vid");

17 element.appendChild(videoTag);	26 element.appendChild(videoTag);
	scherkus (not reviewing) 2011/10/05 20:21:58 you should consider adding a test that makes sure you should consider adding a test that makes sure certain loading-related events aren't fired (i.e., playing, canplay, canplaythrough) Shishir 2011/10/20 21:20:39 Done. Show quoted text On 2011/10/05 20:21:58, scherkus wrote: > you should consider adding a test that makes sure certain loading-related events > aren't fired (i.e., playing, canplay, canplaythrough) Done.
18 </script>	27 </script>

19 </body>	28 </body>

20 </html>	29 </html>

OLD	NEW