chrome/test/data/prerender/prerender_html5_video.html - Issue 8095007: Defer loading of audio/video tags while prerendering.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_html5_video.html

Issue 8095007: Defer loading of audio/video tags while prerendering. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Addressing Andrew's comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/prerender/prerender_html5_audio.html ('K') | « chrome/test/data/prerender/prerender_html5_audio.html ('k') | chrome/test/data/prerender/prerender_html5_video_script.html » ('j') | chrome/test/data/prerender/prerender_html5_video_script.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <!--	2 <!--

3 This test checks that prerender is cancelled when an video tag is	3 This test checks that prerender is cancelled when an video tag is
	scherkus (not reviewing) 2011/10/05 20:21:58 update docs? update docs? Shishir 2011/10/20 21:20:39 Done. Show quoted text On 2011/10/05 20:21:58, scherkus wrote: > update docs? Done.
4 encountered.	4 encountered.

5 -->	5 -->

6 <head>	6 <head>

7 <title>Prerender cancellation for HTML5 video.</title>	7 <title>Prerender cancellation for HTML5 video.</title>
	scherkus (not reviewing) 2011/10/05 20:21:58 ditto ditto Shishir 2011/10/20 21:20:39 Done. Show quoted text On 2011/10/05 20:21:58, scherkus wrote: > ditto Done.
	8

	9 <script>

	10 function DidPrerenderPass() {

	11 return true;

	12 }

	13 function DidDisplayPass() {

	14 return true;

	15 }

	16 </script>

8 </head>	17 </head>

9 <body>	18 <body>

10 <video src="nonexistant.mp4" width="320" height="240" controls="controls">	19 <video src="nonexistant.mp4" width="320" height="240" controls="controls">
	scherkus (not reviewing) 2011/10/05 20:21:58 nit: you don't need to list width/height (in the nit: you don't need to list width/height (in the case of no src it'll default to 300x150 and in the case of a valid src it'll resize itself) nit: controls="controls" -> controls Shishir 2011/10/20 21:20:39 Done. Show quoted text On 2011/10/05 20:21:58, scherkus wrote: > nit: > > you don't need to list width/height (in the case of no src it'll default to > 300x150 and in the case of a valid src it'll resize itself) > > nit: controls="controls" -> controls Done.
11 </video>	20 </video>

12 </body>	21 </body>

13 </html>	22 </html>

OLD	NEW