Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 8094008: Skip non existing directory in gclient recurse (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Skip non existing directory in gclient recurse R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103525

Patch Set 1 #

Total comments: 1

Patch Set 2 : missing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M gclient.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-09-30 19:34:00 UTC) #1
Dirk Pranke
lgtm. http://codereview.chromium.org/8094008/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/8094008/diff/1/gclient.py#newcode1101 gclient.py:1101: print >> sys.stderr, 'Skipped non existing %s' % ...
9 years, 2 months ago (2011-09-30 19:42:01 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8094008/3001
9 years, 2 months ago (2011-09-30 19:50:52 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-09-30 19:56:54 UTC) #4
Change committed as 103525

Powered by Google App Engine
This is Rietveld 408576698