Issue 8094001: More aura build fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8094001: More aura build fixes (Closed)

Created:
9 years, 2 months ago by DaveMoore

Modified:
9 years, 2 months ago

Reviewers:
oshima, sky

CC:
chromium-reviews, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

More aura build fixes BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103473

Patch Set 2 : Removed two in-air patches #

Patch Set 3 : Fixed accidental removal of chrome_browser_main_aura #

Patch Set 4 : Removed other patch #

Total comments: 1

Patch Set 5 : Remove tmp var #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -2 lines)			Patch
A	chrome/app/chrome_exe_main_aura.cc	View	1 2 3 4	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/aura/aura_init.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_exe.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View		1 chunk	+6 lines, -1 line	0 comments	Download
A	ui/gfx/path_aura.cc	View		1 chunk	+36 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/8094001/diff/36/chrome/app/chrome_exe_main_aura.cc File chrome/app/chrome_exe_main_aura.cc (right): http://codereview.chromium.org/8094001/diff/36/chrome/app/chrome_exe_main_aura.cc#newcode17 chrome/app/chrome_exe_main_aura.cc:17: int return_code = ChromeMain(argc, argv); nit: can this ...

9 years, 2 months ago (2011-09-30 16:31:14 UTC) #2

LGTM