Show sync promo at startup

chrome/browser/ui/browser_init.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_INIT_H_
 #define CHROME_BROWSER_UI_BROWSER_INIT_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 46 matching lines @@
                                        Profile* profile,
                                        size_t expected_tabs);
 
   // Returns true if the browser is coming up.
   static bool InProcessStartup();
 
   // Launches a browser window associated with |profile|. |command_line| should
   // be the command line passed to this process. |cur_dir| can be empty, which
   // implies that the directory of the executable should be used.
   // |process_startup| indicates whether this is the first browser.
+  // |is_first_run| indicates that this is a new profile.
   bool LaunchBrowser(const CommandLine& command_line, Profile* profile,
                      const FilePath& cur_dir, bool process_startup,
-                     int* return_code);
+                     bool is_first_run, int* return_code);

[sky, 2011/10/04 15:33:53]

Each param on its own line, here and all other methods.
Also, multiple booleans like this make the code nearly unreadable. Use an enum
(style guide encourages this too).

[sail, 2011/10/04 19:25:22]

Done.

 
   // LaunchWithProfile ---------------------------------------------------------
   //
   // Assists launching the application and appending the initial tabs for a
   // browser window.
 
   class LaunchWithProfile {
    public:
     // Used by OpenTabsInBrowser.
     struct Tab {
@@ skipping 10 matching lines @@
       // True if the is tab pinned.
       bool is_pinned;
 
       // Id of the app.
       std::string app_id;
     };
 
     // There are two ctors. The first one implies a NULL browser_init object
     // and thus no access to distribution-specific first-run behaviors. The
     // second one is always called when the browser starts even if it is not
-    // the first run.
-    LaunchWithProfile(const FilePath& cur_dir, const CommandLine& command_line);
+    // the first run.  |is_first_run| indicates that this is a new profile.
     LaunchWithProfile(const FilePath& cur_dir, const CommandLine& command_line,
-                      BrowserInit* browser_init);
+                      bool is_first_run);
+    LaunchWithProfile(const FilePath& cur_dir, const CommandLine& command_line,
+                      BrowserInit* browser_init, bool is_first_run);
     ~LaunchWithProfile();
 
     // Creates the necessary windows for startup. Returns true on success,
     // false on failure. process_startup is true if Chrome is just
     // starting up. If process_startup is false, it indicates Chrome was
     // already running and the user wants to launch another instance.
     bool Launch(Profile* profile,
                 const std::vector<GURL>& urls_to_open,
                 bool process_startup);
 
@@ skipping 92 matching lines @@
     void AddStartupURLs(std::vector<GURL>* startup_urls) const;
 
     // Checks whether Chrome is still the default browser (unless the user
     // previously instructed not to do so) and warns the user if it is not.
     void CheckDefaultBrowser(Profile* profile);
 
     const FilePath cur_dir_;
     const CommandLine& command_line_;
     Profile* profile_;
     BrowserInit* browser_init_;
+    bool is_first_run_;
     DISALLOW_COPY_AND_ASSIGN(LaunchWithProfile);
   };
 
  private:
   // Returns the list of URLs to open from the command line. The returned
   // vector is empty if the user didn't specify any URLs on the command line.
   static std::vector<GURL> GetURLsFromCommandLine(
       const CommandLine& command_line,
       const FilePath& cur_dir,
       Profile* profile);
 
   static bool ProcessCmdLineImpl(const CommandLine& command_line,
                                  const FilePath& cur_dir, bool process_startup,
                                  Profile* profile, int* return_code,
                                  BrowserInit* browser_init);
 
   // Additional tabs to open during first run.
   std::vector<GURL> first_run_tabs_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserInit);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_INIT_H_