Show sync promo at startup

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/sessions/session_service_factory.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/webui/sync_promo_ui.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "content/browser/browser_thread.h"
 #include "content/common/notification_service.h"
 #include "grit/generated_resources.h"
 #include "net/http/http_transaction_factory.h"
@@ skipping 26 matching lines @@
 // The NewProfileLauncher class is created when to wait for a multi-profile
 // to be created asynchronously. Upon completion of profile creation, the
 // NPL takes care of launching a new browser window and signing the user
 // in to their Google account.
 class NewProfileLauncher : public ProfileManagerObserver {
  public:
   virtual void OnProfileCreated(Profile* profile, Status status) {
     if (status == STATUS_INITIALIZED) {
       DCHECK(profile);
       Browser* browser = Browser::Create(profile);
-      browser->AddSelectedTabWithURL(GURL(chrome::kChromeUINewTabURL),
-                                     PageTransition::LINK);
+      GURL url;

[sky, 2011/10/01 20:32:42]

This doesn't seem right. Shouldn't we be calling into browser_init here?
Otherwise we're not doing session restore and other random things we might want
to trigger.

[sail, 2011/10/01 21:37:34]

This code is only called if the user adds a new profile by clicking the "Add
profile" button. At this point we'd never want to do session restore or open the
welcome page here.

Are you sure we should still be calling browser_init from here?

+      if (SyncPromoUI::ShouldShowSyncPromoAtStartup(profile, true)) {
+        SyncPromoUI::DidShowSyncPromoAtStartup(profile);
+        url = GURL(chrome::kChromeUISyncPromoURL);
+      } else {
+        url = GURL(chrome::kChromeUINewTabURL);
+      }
+      browser->AddSelectedTabWithURL(url, PageTransition::LINK);
       browser->window()->Show();
     }
   }
 
   virtual bool DeleteAfter() OVERRIDE { return true; }
 };
 
 // static
 void ProfileManager::ShutdownSessionServices() {
   ProfileManager* pm = g_browser_process->profile_manager();
@@ skipping 499 matching lines @@
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }
 
 void ProfileManager::RegisterTestingProfile(Profile* profile,
                                             bool add_to_cache) {
   RegisterProfile(profile, true);
   if (add_to_cache)
     AddProfileToCache(profile);
 }