Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Unified Diff: chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the nits and rebased on ToT (which now has PART1 in). Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/system_settings_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc b/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc
index 359a1930e08cb177cff2eae2c37d2be98607a5c5..1d629565bcd9c363e1abaae63136d8c45603fad3 100644
--- a/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc
+++ b/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc
@@ -197,15 +197,15 @@ SystemSettingsProvider::~SystemSettingsProvider() {
STLDeleteElements(&timezones_);
}
-void SystemSettingsProvider::DoSet(const std::string& path, Value* in_value) {
+void SystemSettingsProvider::DoSet(const std::string& path,
+ const base::Value& in_value) {
// Non-guest users can change the time zone.
if (UserManager::Get()->IsLoggedInAsGuest())
return;
if (path == kSystemTimezone) {
string16 value;
- if (!in_value || !in_value->IsType(Value::TYPE_STRING) ||
- !in_value->GetAsString(&value))
+ if (!in_value.IsType(Value::TYPE_STRING) || !in_value.GetAsString(&value))
return;
const icu::TimeZone* timezone = GetTimezone(value);
if (!timezone)
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/system_settings_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698