chrome/browser/chromeos/login/signed_settings_helper_unittest.cc - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed the nits and rebased on ToT (which now has PART1 in). Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/signed_settings_helper.cc ('k') | chrome/browser/chromeos/login/signed_settings_temp_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

diff --git a/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc b/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

index 7f19868cef190027d31817e8df4907278636b4e2..7b5ad5b60a10f40c9cd644365461a5187a002af7 100644

--- a/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

+++ b/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

@@ -41,11 +41,11 @@ class MockSignedSettingsHelperCallback : public SignedSettingsHelper::Callback {

MOCK_METHOD3(OnStorePropertyCompleted, void(

SignedSettings::ReturnCode code,

const std::string& name,

- const std::string& value));

+ const base::Value& value));

MOCK_METHOD3(OnRetrievePropertyCompleted, void(

SignedSettings::ReturnCode code,

const std::string& name,

- const std::string& value));

+ const base::Value* value));

};

class SignedSettingsHelperTest : public testing::Test,

@@ -53,7 +53,7 @@ class SignedSettingsHelperTest : public testing::Test,

public:

SignedSettingsHelperTest()

: fake_email_("fakey@example.com"),

- fake_prop_(kAccountsPrefAllowGuest),

+ fake_prop_(kReleaseChannel),

fake_value_("false"),

message_loop_(MessageLoop::TYPE_UI),

ui_thread_(BrowserThread::UI, &message_loop_),

@@ -100,7 +100,7 @@ class SignedSettingsHelperTest : public testing::Test,

const std::string fake_email_;

const std::string fake_prop_;

- const std::string fake_value_;

+ const base::StringValue fake_value_;

MockOwnershipService m_;

MessageLoop message_loop_;