Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: chrome/browser/chromeos/login/signed_settings.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the nits and rebased on ToT (which now has PART1 in). Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signed_settings.h
diff --git a/chrome/browser/chromeos/login/signed_settings.h b/chrome/browser/chromeos/login/signed_settings.h
index a423aaed70ccd5234a6ca2e29bce56d7e5f9abc2..a4839620924e1aefab899dcf3d71db44a9a12610 100644
--- a/chrome/browser/chromeos/login/signed_settings.h
+++ b/chrome/browser/chromeos/login/signed_settings.h
@@ -30,6 +30,10 @@
// and then call the appropriate method of the Delegate you passed in
// -- again, on the UI thread.
+namespace base {
+class Value;
+} // namespace base
+
namespace enterprise_management {
class PolicyFetchResponse;
class PolicyData;
@@ -74,12 +78,12 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
// one type can be in flight at a time.
static SignedSettings* CreateStorePropertyOp(
const std::string& name,
- const std::string& value,
+ const base::Value& value,
SignedSettings::Delegate<bool>* d);
static SignedSettings* CreateRetrievePropertyOp(
const std::string& name,
- SignedSettings::Delegate<std::string>* d);
+ SignedSettings::Delegate<const base::Value*>* d);
// These are both "policy" operations, and only one instance of
// one type can be in flight at a time.
« no previous file with comments | « chrome/browser/chromeos/login/mock_signed_settings_helper.h ('k') | chrome/browser/chromeos/login/signed_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698