Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the nits and rebased on ToT (which now has PART1 in). Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros_settings_provider.cc ('k') | chrome/browser/chromeos/login/login_performer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 6e53b27d7f94b97a1db08e79ae8f6472bad6808c..74ab5af83679807b7d13a3ac265aa88398579c42 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -102,14 +102,12 @@ void ExistingUserController::Init(const UserList& users) {
&show_users_on_signin);
if (show_users_on_signin) {
bool allow_new_user = false;
- const base::ListValue *user_list;
cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
- cros_settings_->GetList(kAccountsPrefUsers, &user_list);
for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {
- base::StringValue email((*it)->email());
// TODO(xiyuan): Clean user profile whose email is not in whitelist.
if (allow_new_user ||
- user_list->Find(email) != user_list->end()) {
+ cros_settings_->FindEmailInList(kAccountsPrefUsers,
+ (*it)->email())) {
filtered_users.push_back(*it);
}
}
« no previous file with comments | « chrome/browser/chromeos/cros_settings_provider.cc ('k') | chrome/browser/chromeos/login/login_performer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698