chrome/browser/chromeos/proxy_config_service_impl.h - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT+Part1 and addressed comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/signed_settings_helper.h ('K') | « chrome/browser/chromeos/login/wizard_controller.cc ('k') | chrome/browser/chromeos/proxy_config_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/proxy_config_service_impl.h

diff --git a/chrome/browser/chromeos/proxy_config_service_impl.h b/chrome/browser/chromeos/proxy_config_service_impl.h

index b059080415bb9c678950d5f6151e666ecfc3b011..4cb5b878a5d1c00e311dc2fd6e00a2db19682c24 100644

--- a/chrome/browser/chromeos/proxy_config_service_impl.h

+++ b/chrome/browser/chromeos/proxy_config_service_impl.h

@@ -35,7 +35,7 @@ namespace chromeos {

// user profile

class ProxyConfigServiceImpl

: public PrefProxyConfigTrackerImpl,

- public SignedSettings::Delegate<std::string>,

+ public SignedSettings::Delegate<const base::Value*>,

public NetworkLibrary::NetworkManagerObserver,

public NetworkLibrary::NetworkObserver {

public:

@@ -193,7 +193,7 @@ class ProxyConfigServiceImpl

// Implementation for SignedSettings::Delegate

virtual void OnSettingsOpCompleted(SignedSettings::ReturnCode code,

- std::string value) OVERRIDE;

+ const base::Value* value) OVERRIDE;

// NetworkLibrary::NetworkManagerObserver implementation.

virtual void OnNetworkManagerChanged(NetworkLibrary* cros) OVERRIDE;