chrome/browser/chromeos/login/signed_settings_temp_storage.h - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signed_settings_temp_storage.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT+Part1 and addressed comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/signed_settings_helper.h ('K') | « chrome/browser/chromeos/login/signed_settings_helper_unittest.cc ('k') | chrome/browser/chromeos/login/signed_settings_temp_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signed_settings_temp_storage.h

diff --git a/chrome/browser/chromeos/login/signed_settings_temp_storage.h b/chrome/browser/chromeos/login/signed_settings_temp_storage.h

index f7ae0f52f2a70a3a48a6060e109802a9767e1763..f8d4b6d3b97d1d77572c6ad719073071023595cd 100644

--- a/chrome/browser/chromeos/login/signed_settings_temp_storage.h

+++ b/chrome/browser/chromeos/login/signed_settings_temp_storage.h

@@ -9,6 +9,7 @@

#include <string>

#include "base/basictypes.h"

+#include "base/values.h"

class PrefService;

@@ -24,10 +25,10 @@ class SignedSettingsTempStorage {

static void RegisterPrefs(PrefService* local_state);

static bool Store(const std::string& name,

- const std::string& value,

+ const base::Value& value,

PrefService* local_state);

static bool Retrieve(const std::string& name,

- std::string* value,

+ base::Value** value,

PrefService* local_state);

// Call this after owner has been assigned to persist settings